Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix rolling stock livery display #9757

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

Akctarus
Copy link
Contributor

closes #8289

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus requested a review from a team as a code owner November 18, 2024 10:40
@Akctarus Akctarus changed the title Tmn/front/fix rolling stock livery display front: fix rolling stock livery display Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.85%. Comparing base (a4daa6d) to head (306a6e2).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9757      +/-   ##
==========================================
- Coverage   37.85%   37.85%   -0.01%     
==========================================
  Files         990      990              
  Lines       90928    90966      +38     
  Branches     1176     1176              
==========================================
+ Hits        34423    34433      +10     
- Misses      56051    56079      +28     
  Partials      454      454              
Flag Coverage Δ
editoast 73.27% <ø> (-0.04%) ⬇️
front 20.10% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you, waited for that since a long time !

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/fix-rolling-stock-livery-display branch from c8925b7 to 306a6e2 Compare November 18, 2024 16:34
@Akctarus Akctarus enabled auto-merge November 18, 2024 16:34
@Akctarus Akctarus added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit c18da7a Nov 18, 2024
27 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-rolling-stock-livery-display branch November 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1TGVDUPL livery is weird in the tab
4 participants