Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix font weight in input timestop table #9735

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 16, 2024

Close #9732

Bug introduced in #8861, looking at the pr it stands to reason that .active is supposed to be specialized to micro macro buttons. Inspecting the page, it does not seem that any other element affected by the pr was using the .active class.

Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar Synar requested a review from a team as a code owner November 16, 2024 09:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.82%. Comparing base (e67214e) to head (3cb4137).
Report is 58 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9735      +/-   ##
============================================
- Coverage     42.49%   37.82%   -4.67%     
============================================
  Files          1312      990     -322     
  Lines        105608    90921   -14687     
  Branches       3305     1176    -2129     
============================================
- Hits          44878    34395   -10483     
+ Misses        58777    56072    -2705     
+ Partials       1953      454    -1499     
Flag Coverage Δ
core ?
editoast 73.21% <ø> (-0.51%) ⬇️
front 20.11% <ø> (+1.32%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@Synar Synar added this pull request to the merge queue Nov 19, 2024
Merged via the queue into dev with commit bcc839c Nov 19, 2024
27 checks passed
@Synar Synar deleted the ali/fix-font-in-input-timestops-table branch November 19, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All entries of input table are bold
4 participants