Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: allow Model fields order to differ from table columns' #9689

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Nov 13, 2024

fixes #9468

@leovalais leovalais requested a review from a team as a code owner November 13, 2024 11:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.86%. Comparing base (da5c5b1) to head (bf681ce).
Report is 42 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9689      +/-   ##
============================================
- Coverage     42.49%   37.86%   -4.63%     
============================================
  Files          1312      990     -322     
  Lines        105608    90955   -14653     
  Branches       3305     1176    -2129     
============================================
- Hits          44881    34443   -10438     
+ Misses        58774    56058    -2716     
+ Partials       1953      454    -1499     
Flag Coverage Δ
core ?
editoast 73.31% <100.00%> (-0.42%) ⬇️
front 20.11% <ø> (+1.31%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin
Copy link
Contributor

@dependabot rebase

Signed-off-by: Leo Valais <leo.valais97@gmail.com>
Signed-off-by: Leo Valais <leo.valais97@gmail.com>
@leovalais leovalais force-pushed the lva/fix-model-field-order branch from 5f728ce to f66200c Compare November 14, 2024 21:35
Signed-off-by: Leo Valais <leo.valais97@gmail.com>
Signed-off-by: Leo Valais <leo.valais97@gmail.com>
@leovalais leovalais requested a review from woshilapin November 18, 2024 11:22
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for that QoL improvement.

@leovalais leovalais added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit 36eb346 Nov 18, 2024
27 checks passed
@leovalais leovalais deleted the lva/fix-model-field-order branch November 18, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: cannot declare Model fields in different order from the table's columns
3 participants