Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: handle non-stop transitions for NGE → OSRD conversion #9680

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Nov 12, 2024

To test: mark a transition as non-stop in NGE, the change should be reflected in OSRD.

Closes: #9638

@emersion emersion requested a review from a team as a code owner November 12, 2024 09:31
@emersion emersion self-assigned this Nov 12, 2024
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@emersion emersion removed their assignment Nov 15, 2024
Copy link
Contributor

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working perfectly, thanks !

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested thank you.
I think it also fixes the bug #9332

The ESLint no-restricted-syntax lint has been disabled globally,
and the TODO has been resolved when introducing
getTrainrunSectionsByTrainrunId().

Signed-off-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr>
@emersion emersion enabled auto-merge November 15, 2024 13:52
@emersion emersion added this pull request to the merge queue Nov 15, 2024
Merged via the queue into dev with commit 432baa4 Nov 15, 2024
27 checks passed
@emersion emersion deleted the nge-non-stop branch November 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGE->OSRD conversion schedules all intermediary vias as 0s stops
4 participants