editoast: fix all units about rolling resistance #9666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
added
kind:bug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## dev #9666 +/- ##
=============================================
- Coverage 42.51% 30.41% -12.10%
- Complexity 2271 2272 +1
=============================================
Files 1311 1041 -270
Lines 105413 77197 -28216
Branches 3297 3304 +7
=============================================
- Hits 44812 23482 -21330
+ Misses 58655 51762 -6893
- Partials 1946 1953 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
approved these changes
Nov 15, 2024
The database is populated with SI units, which means Newton, kg, meter and seconds. Another important piece of information is: - Units of rolling resistance for traction engines (also named rolling stocks) are in N, N/(m/s) and N/(m/s)² - Units of rolling resistance for towed rolling stocks are in (N/kg), (N/kg)/(m/s) and (N/kg)/(m/s)². Therefore, we need 2 different `struct` for storing those, hence the introduction of `RollingResistancePerWeight`. Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
woshilapin
force-pushed
the
wsl/editoast/9657-fix-consists-rolling-resistance
branch
from
81beeb0 to
3433850
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
woshilapin
deleted the
wsl/editoast/9657-fix-consists-rolling-resistance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9657 (or we hope it does at least).
The database is populated with SI units, which means Newton, kg, meter and seconds.
Another important piece of information is:
Therefore, we need 2 different
structfor storing those, hence the introduction ofRollingResistancePerWeight.