Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add script and dockerfiles checks to github build action #9658

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 8, 2024

Close #9650

@Synar Synar requested a review from a team as a code owner November 8, 2024 12:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.48%. Comparing base (e67214e) to head (2e26358).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9658      +/-   ##
============================================
- Coverage     42.49%   42.48%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105608   105608              
  Branches       3305     3305              
============================================
- Hits          44878    44867      -11     
- Misses        58777    58788      +11     
  Partials       1953     1953              
Flag Coverage Δ
core 74.95% <ø> (ø)
editoast 73.68% <ø> (-0.04%) ⬇️
front 18.79% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch 9 times, most recently from 9f0e871 to d5a7760 Compare November 8, 2024 13:28
@Synar Synar requested a review from a team as a code owner November 8, 2024 13:28
@Synar Synar requested a review from eckter November 8, 2024 13:28
@github-actions github-actions bot added the area:core Work on Core Service label Nov 8, 2024
@Synar
Copy link
Contributor Author

Synar commented Nov 8, 2024

image
When introducing a capitalization difference that would generate a docker warning the CI correctly identifies it and fails

@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from d5a7760 to c9daa1d Compare November 8, 2024 13:32
@github-actions github-actions bot removed the area:core Work on Core Service label Nov 8, 2024
@Synar
Copy link
Contributor Author

Synar commented Nov 8, 2024

Welp looks like my test on the core dockerfile automatically requested your review @eckter , sorry for that ^^

@Synar
Copy link
Contributor Author

Synar commented Nov 8, 2024

The shellcheck test also seems to be working properly. Sadly it looks like we did not need to simulate a warning this time...
Linting fixes coming as a second commit, though perhaps we will need to ignore some .
image

@Khoyo
Copy link
Contributor

Khoyo commented Nov 8, 2024

You clearly need to exclude /core/gradlew. It's a generated wrapper for gradle.

@Synar Synar requested a review from a team as a code owner November 8, 2024 14:33
@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from 798cd09 to 3d7d4b9 Compare November 8, 2024 14:44
@Synar
Copy link
Contributor Author

Synar commented Nov 8, 2024

What severity do we care about for shellcheck? Do we want to catch styling and info messages, or only warnings and errors?

I guess we could keep the default (catching all severity levels) unless and until it becomes an issue

@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from 3d7d4b9 to 3e84506 Compare November 8, 2024 15:14
@Synar Synar requested a review from a team as a code owner November 8, 2024 15:14
@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from b7fd246 to 9ee9934 Compare November 8, 2024 16:24
@Synar Synar enabled auto-merge November 12, 2024 11:36
@Synar Synar disabled auto-merge November 12, 2024 11:36
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@Khoyo Khoyo enabled auto-merge November 13, 2024 02:28
@Khoyo Khoyo disabled auto-merge November 13, 2024 02:28
scripts/cleanup-db.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed adding names:

  • check_reuse_compliance
  • end_to_end_tests
  • integration_tests
  • check_osrdyne
  • check_gateway
  • check_editoast_openapi
  • check_editoast_lints
  • check_editoast_tests
  • check_core
  • check_front_rtk_sync
  • check_reuse_compliance
  • check_infra_schema_sync

And additionally label_pr (not in build:yml)

@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from 093c142 to 1127114 Compare November 13, 2024 13:45
@Synar
Copy link
Contributor Author

Synar commented Nov 13, 2024

Missed adding names:

* check_reuse_compliance

* end_to_end_tests

* integration_tests

* check_osrdyne

* check_gateway

* check_editoast_openapi

* check_editoast_lints

* check_editoast_tests

* check_core

* check_front_rtk_sync

* check_reuse_compliance

* check_infra_schema_sync

And additionally label_pr (not in build:yml)

Oups messed up my commit. I did not think to add a name to label_pr though, will do so.

@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from 1127114 to 2e623f7 Compare November 13, 2024 13:50
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from 2e623f7 to 5baa897 Compare November 13, 2024 13:50
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar Synar force-pushed the ali/add-dockerfile-and-script-checks-to-ci branch from 5baa897 to 2e26358 Compare November 13, 2024 14:23
@Synar Synar requested a review from Khoyo November 13, 2024 15:30
@Khoyo Khoyo merged commit 6600f73 into dev Nov 13, 2024
27 checks passed
@Khoyo Khoyo deleted the ali/add-dockerfile-and-script-checks-to-ci branch November 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI : add CI checks to scripts and dockerfiles
6 participants