-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add script and dockerfiles checks to github build action #9658
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9658 +/- ##
============================================
- Coverage 42.49% 42.48% -0.02%
Complexity 2272 2272
============================================
Files 1312 1312
Lines 105608 105608
Branches 3305 3305
============================================
- Hits 44878 44867 -11
- Misses 58777 58788 +11
Partials 1953 1953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f0e871
to
d5a7760
Compare
d5a7760
to
c9daa1d
Compare
Welp looks like my test on the core dockerfile automatically requested your review @eckter , sorry for that ^^ |
You clearly need to exclude |
798cd09
to
3d7d4b9
Compare
What severity do we care about for shellcheck? Do we want to catch styling and info messages, or only warnings and errors? I guess we could keep the default (catching all severity levels) unless and until it becomes an issue |
3d7d4b9
to
3e84506
Compare
b7fd246
to
9ee9934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed adding names:
- check_reuse_compliance
- end_to_end_tests
- integration_tests
- check_osrdyne
- check_gateway
- check_editoast_openapi
- check_editoast_lints
- check_editoast_tests
- check_core
- check_front_rtk_sync
- check_reuse_compliance
- check_infra_schema_sync
And additionally label_pr (not in build:yml
)
093c142
to
1127114
Compare
Oups messed up my commit. I did not think to add a name to label_pr though, will do so. |
1127114
to
2e623f7
Compare
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
2e623f7
to
5baa897
Compare
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
5baa897
to
2e26358
Compare
Close #9650