editoast: use DateTime with timezone in work schedule API #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
approved these changes
Nov 8, 2024
emersion
force-pushed
the
emr/work-schedule-tz
branch
from
f01986e to
fd55d57
Compare
emersion
force-pushed
the
emr/work-schedule-tz
branch
from
fd55d57 to
cf5690b
Compare
|
If this is deemed too intrusive for a bugfix, we could fix only the GET side of the API as a first step, and take more time to merge the POST side (and adapt the various users). |
emersion
force-pushed
the
emr/work-schedule-tz
branch
2 times, most recently
from
7063a02 to
506a107
Compare
bloussou
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Check with @Morgane-SJK no problem we are already using TZ everywhere in elt code
The timezone was stored in the database, but was stripped at the HTTP API boundary. This is a breaking change: the timezone is required when submitting a work schedule, and is always returned when projecting a work schedule. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/work-schedule-tz
branch
from
506a107 to
f65d82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timezone was stored in the database, but was stripped at the HTTP API boundary.
This is a breaking change: the timezone is required when submitting a work schedule, and is always returned when projecting a work schedule.
Closes: #9652