Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: rename all test modules to follow rust idiom #9645

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Sh099078
Copy link
Contributor

@Sh099078 Sh099078 commented Nov 7, 2024

While the majority of editoast test modules are called "tests", some are mistakenly called "test". Rename all test modules to "tests" so that they follow rust idiom.

While the majority of editoast test modules are called "tests", some are
mistakenly called "test". Rename all test modules to "tests" so that they
follow rust idiom.

Signed-off-by: Loup Federico <16464925+Sh099078@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.50%. Comparing base (a92037a) to head (17ffe37).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/generated_data/error/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9645      +/-   ##
============================================
- Coverage     42.51%   42.50%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105555   105563       +8     
  Branches       3304     3304              
============================================
- Hits          44879    44871       -8     
- Misses        58723    58739      +16     
  Partials       1953     1953              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.74% <0.00%> (-0.04%) ⬇️
front 18.79% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <0.00%> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sh099078 Sh099078 marked this pull request as ready for review November 7, 2024 19:23
@Sh099078 Sh099078 requested a review from a team as a code owner November 7, 2024 19:23
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Sh099078 Sh099078 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit 8461f3e Nov 7, 2024
25 checks passed
@Sh099078 Sh099078 deleted the lf/rename-test-modules branch November 7, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants