Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix op search in infra editor #9643

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Nov 7, 2024

closes #8616

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus requested a review from a team as a code owner November 7, 2024 16:32
@Akctarus Akctarus requested a review from SharglutDev November 7, 2024 16:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.50%. Comparing base (a92037a) to head (ebb77e8).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/common/Map/Search/useSearchOperationalPoint.tsx 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9643      +/-   ##
============================================
- Coverage     42.51%   42.50%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105555   105557       +2     
  Branches       3304     3304              
============================================
- Hits          44879    44868      -11     
- Misses        58723    58736      +13     
  Partials       1953     1953              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.73% <ø> (-0.04%) ⬇️
front 18.79% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani self-requested a review November 7, 2024 16:45
@Akctarus Akctarus requested review from Caracol3 and removed request for SharglutDev November 8, 2024 08:32
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on germany infra. Nice work !

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Akctarus Akctarus added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@Akctarus Akctarus added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit 2263ea1 Nov 8, 2024
25 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-op-search branch November 8, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object search isn't resilient to operational points with no ch code
4 participants