Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: warn when invalid detector is found #9604

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

bougue-pe
Copy link
Contributor

Very small part of #9389

@bougue-pe bougue-pe requested a review from a team as a code owner November 6, 2024 17:21
@bougue-pe bougue-pe requested a review from Erashin November 6, 2024 17:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.84%. Comparing base (cb99790) to head (02a35bd).
Report is 22 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #9604   +/-   ##
=======================================
  Coverage   37.84%   37.84%           
=======================================
  Files         990      990           
  Lines       90915    90920    +5     
  Branches     1176     1176           
=======================================
+ Hits        34404    34406    +2     
- Misses      56057    56060    +3     
  Partials      454      454           
Flag Coverage Δ
editoast 73.25% <ø> (+<0.01%) ⬆️
front 20.11% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo
Copy link
Contributor

Khoyo commented Nov 6, 2024

(you need to run ./gradlew spotlessApply)

@bougue-pe bougue-pe force-pushed the peb/core/warn_invalid_detector branch 2 times, most recently from 3f681f1 to 61aba19 Compare November 7, 2024 16:46
Signed-off-by: Pierre-Etienne Bougué <bougue.pe@proton.me>
@bougue-pe bougue-pe force-pushed the peb/core/warn_invalid_detector branch from 61aba19 to 02a35bd Compare November 15, 2024 20:25
@bougue-pe bougue-pe added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit 99d0adb Nov 18, 2024
27 checks passed
@bougue-pe bougue-pe deleted the peb/core/warn_invalid_detector branch November 18, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants