Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix capitalized text in stdcm table results #9593

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Nov 6, 2024

closes #9525

@Akctarus Akctarus requested a review from a team as a code owner November 6, 2024 13:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.49%. Comparing base (95c1305) to head (6ce1172).
Report is 28 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9593      +/-   ##
============================================
- Coverage     42.57%   42.49%   -0.08%     
- Complexity     2271     2272       +1     
============================================
  Files          1311     1312       +1     
  Lines        105246   105570     +324     
  Branches       3296     3304       +8     
============================================
+ Hits          44810    44865      +55     
- Misses        58490    58752     +262     
- Partials       1946     1953       +7     
Flag Coverage Δ
core 75.05% <ø> (-0.01%) ⬇️
editoast 73.72% <ø> (+0.02%) ⬆️
front 18.79% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (-0.32%) ⬇️
osrdyne 3.28% <ø> (+<0.01%) ⬆️
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/fix-typos-in-stdcm-table-results branch from 36a66c4 to fda0328 Compare November 6, 2024 13:29
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@Akctarus Akctarus requested a review from SarahBellaha November 6, 2024 13:50
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akctarus Akctarus requested a review from emersion November 7, 2024 09:44
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/fix-typos-in-stdcm-table-results branch from cf88550 to 6ce1172 Compare November 8, 2024 13:06
@Akctarus Akctarus enabled auto-merge November 8, 2024 13:06
@Akctarus Akctarus added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit ec33501 Nov 8, 2024
25 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-typos-in-stdcm-table-results branch November 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: typo in simulation result
5 participants