Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm linked path enhancement #9567

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha commented Nov 5, 2024

Partially closes #9545

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.95431% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (5af6621) to head (20fa850).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 40.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9567      +/-   ##
==========================================
- Coverage   79.82%   79.81%   -0.02%     
==========================================
  Files        1054     1054              
  Lines      105544   105536       -8     
  Branches      727      727              
==========================================
- Hits        84254    84231      -23     
- Misses      21248    21263      +15     
  Partials       42       42              
Flag Coverage Δ
editoast 73.68% <ø> (-0.05%) ⬇️
front 89.14% <96.95%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha marked this pull request as ready for review November 5, 2024 10:02
@SarahBellaha SarahBellaha requested a review from a team as a code owner November 5, 2024 10:02
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-enhancement branch from 2013652 to 5b48a87 Compare November 5, 2024 14:47
front/src/applications/stdcm/types.ts Outdated Show resolved Hide resolved
front/src/reducers/osrdconf/stdcmConf/index.ts Outdated Show resolved Hide resolved
front/public/locales/en/stdcm.json Outdated Show resolved Hide resolved
@clarani
Copy link
Contributor

clarani commented Nov 28, 2024

Very nice PR, thanks 🙏
Can you group all the changes related to the renaming in the first commit ? If you need help, we can do it together 👍
Also, I found some forgotten linkedPath:

  • in updateLinkedPathStep (maybe updateLinkedPathExtremity ?)

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments above opened. Do you want to squash your commits or keep them separated ? If you want to keep them separated, you can force push on the branch 👍

@clarani clarani self-requested a review December 4, 2024 14:29
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-enhancement branch from 073b940 to 4db77c0 Compare December 5, 2024 08:26
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 5, 2024
front/public/locales/en/stdcm.json Outdated Show resolved Hide resolved
front/src/reducers/osrdconf/stdcmConf/index.ts Outdated Show resolved Hide resolved
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-enhancement branch from 4db77c0 to 5564a35 Compare December 17, 2024 15:34
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Signed-off-by: SarahBellaha <sarah.bellaha@sncf.fr>
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-enhancement branch from 5564a35 to 20fa850 Compare December 17, 2024 17:04
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 18, 2024
Merged via the queue into dev with commit ef69c8d Dec 18, 2024
27 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/stdcm-linked-path-enhancement branch December 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: refacto and improvements for the linked path
4 participants