-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: stdcm linked path enhancement #9567
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9567 +/- ##
==========================================
- Coverage 79.82% 79.81% -0.02%
==========================================
Files 1054 1054
Lines 105544 105536 -8
Branches 727 727
==========================================
- Hits 84254 84231 -23
- Misses 21248 21263 +15
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2013652
to
5b48a87
Compare
Very nice PR, thanks 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments above opened. Do you want to squash your commits or keep them separated ? If you want to keep them separated, you can force push on the branch 👍
073b940
to
4db77c0
Compare
4db77c0
to
5564a35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Signed-off-by: SarahBellaha <sarah.bellaha@sncf.fr>
5564a35
to
20fa850
Compare
Partially closes #9545