editoast: refactoring STDCM handler

[hamz2a]

closes #9476

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.61538% with 66 lines in your changes missing coverage. Please review.

Project coverage is 37.86%. Comparing base (160ef24) to head (b2cf36b).
Report is 31 commits behind head on dev.

Files with missing lines	Patch %	Lines
editoast/src/views/timetable/stdcm/request.rs	77.71%	37 Missing ⚠️
editoast/src/core/conflict_detection.rs	34.78%	15 Missing ⚠️
editoast/src/views/timetable/stdcm.rs	92.48%	10 Missing ⚠️
editoast/src/models/work_schedules.rs	90.62%	3 Missing ⚠️
editoast/src/core/simulation.rs	90.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9509      +/-   ##
==========================================
+ Coverage   37.84%   37.86%   +0.01%     
==========================================
  Files         990      992       +2     
  Lines       90920    90973      +53     
  Branches     1176     1176              
==========================================
+ Hits        34413    34451      +38     
- Misses      56053    56068      +15     
  Partials      454      454              

Flag	Coverage Δ
editoast	73.32% <84.61%> (+0.04%)	⬆️
front	20.10% <ø> (-0.01%)	⬇️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[eckter]

Before checking the code itself: do we want to merge it during the feature freeze? Are there bug fixes in there, or is it just moving code around?

[hamz2a]

Before checking the code itself: do we want to merge it during the feature freeze? Are there bug fixes in there, or is it just moving code around?

This is purely a refactoring with no functional changes.
Are there any risks you see that would block merging it during the freeze?

[woshilapin]

Thanks for the addressed comments from #9434.

[eckter]

This is purely a refactoring with no functional changes.
Are there any risks you see that would block merging it during the freeze?

The same as any kind of change, bugs. I believe refactorings are even more "unstable" than new features as they affect what's already there and not just new things.

This specific part of the code that translates front inputs into core payloads is especially sensitive. It's poorly tested and it's difficult to track problems there, and we've had issues recently. At a time where we're working on stabilizing stdcm, it would be painful to introduce instability.

Let's talk about this on matrix, it's not about this PR specifically.

[leovalais]

Thanks for all this work, it looks much more organized now! I left a bunch of comments which are mostly about:

• module organization
• visibility being more permissive than required (I didn't add a comment in all places)
• naming

It would be nice to have some module-level documentation in stdcm.rs describing the whole workflow still, even if it's much clearer now thanks to structure.

I'm not as worried about bugs as @eckter is: we already released a tested version and we're shooting demo videos very soon. I'd say that if a bug arises we're better off fixing it in the refactored code directly since this won't impact the PIP. I'm fine with waiting until the end of the week before merging in case a critical bug happens preventing us from shooting the videos, but there's no point in waiting after that point imo. Wdyt?

[SharglutDev]

Lgtm for front part (not tested, we were'nt handling this status anymore)

[leovalais]

Thanks for the changes!

[eckter]

Much clearer, thanks 👍

I've noticed a couple weird things (that were already there in the previous version), I've commented them and I'll check further

[leovalais]

LGTM. Thanks for the changes!