Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add error when stdcm requests don't end with a stop #7919

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jul 2, 2024

No description provided.

@eckter eckter requested review from a team as code owners July 2, 2024 12:36
@eckter eckter requested a review from Erashin July 2, 2024 12:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.48%. Comparing base (e0f4f41) to head (67ede2b).

Files Patch % Lines
...n/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7919      +/-   ##
============================================
- Coverage     28.49%   28.48%   -0.01%     
  Complexity     2059     2059              
============================================
  Files          1254     1254              
  Lines        154467   154469       +2     
  Branches       3047     3047              
============================================
- Hits          44011    43999      -12     
- Misses       108641   108655      +14     
  Partials       1815     1815              
Flag Coverage Δ
core 75.00% <33.33%> (-0.01%) ⬇️
editoast 71.64% <ø> (-0.05%) ⬇️
front 9.97% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/add-error-missing-last-stop branch from 04d5938 to 67ede2b Compare July 2, 2024 13:05
@eckter eckter enabled auto-merge July 2, 2024 13:05
@eckter eckter added this pull request to the merge queue Jul 2, 2024
Merged via the queue into dev with commit d6f255b Jul 2, 2024
17 checks passed
@eckter eckter deleted the ech/add-error-missing-last-stop branch July 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants