docker: port is an integer #7902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `docker-compose.host.yml` is used to override values of `docker-compose.yml`, and `EDITOAST_PORT` is defined as an integer in the latter, tools like `podman` will refuse to merge the 2 files since the value of `EDITOAST_PORT` is a different type. ``` ValueError: can't merge value of EDITOAST_PORT of type <class 'int'> and <class 'str'> ```
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7902 +/- ##
============================================
+ Coverage 28.47% 28.53% +0.06%
- Complexity 2028 2059 +31
============================================
Files 1242 1249 +7
Lines 153143 154182 +1039
Branches 3004 3036 +32
============================================
+ Hits 43611 44000 +389
- Misses 107744 108372 +628
- Partials 1788 1810 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emersion
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
docker-compose.host.ymlis used to override values ofdocker-compose.yml, andEDITOAST_PORTis defined as an integer in the latter, tools likepodmanwill refuse to merge the 2 files since the value ofEDITOAST_PORTis a different type.