-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: avoid x scroll on map search #7899
Conversation
Fix #7185 Using flex with grow/shrink instead of width 100% ; specify x-overflow hidden (even if now the case should not be possible)
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7899 +/- ##
============================================
- Coverage 28.54% 28.53% -0.02%
Complexity 2059 2059
============================================
Files 1249 1249
Lines 154182 154182
Branches 3036 3036
============================================
- Hits 44009 43989 -20
- Misses 108363 108383 +20
Partials 1810 1810
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix ! Do we need width/flex grow/shrink ? It seems it's working without
Have you tested on chrome ? To avoid scroll and use the full size of a div, I generally use flex, grow & shrink pattern. |
Yes even on chrome, it works without the grow/shrink/width:100%. But if you think it's gonna be more resilient with these properties, its fine by me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
Fix #7185
Using flex with grow/shrink instead of width 100% and specify x-overflow hidden (even if now the case should not be possible).
Now it works on both firefox & chrome