Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: avoid x scroll on map search #7899

Merged
merged 1 commit into from
Jul 3, 2024
Merged

front: avoid x scroll on map search #7899

merged 1 commit into from
Jul 3, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Jul 1, 2024

Fix #7185

Using flex with grow/shrink instead of width 100% and specify x-overflow hidden (even if now the case should not be possible).
Now it works on both firefox & chrome

Fix #7185

Using flex with grow/shrink instead of width 100% ; specify x-overflow
hidden (even if now the case should not be possible)
@sim51 sim51 requested a review from a team as a code owner July 1, 2024 11:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.53%. Comparing base (7353c7a) to head (99d9ad4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7899      +/-   ##
============================================
- Coverage     28.54%   28.53%   -0.02%     
  Complexity     2059     2059              
============================================
  Files          1249     1249              
  Lines        154182   154182              
  Branches       3036     3036              
============================================
- Hits          44009    43989      -20     
- Misses       108363   108383      +20     
  Partials       1810     1810              
Flag Coverage Δ
core 74.95% <ø> (ø)
editoast 71.61% <ø> (-0.07%) ⬇️
front 10.00% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 enabled auto-merge July 1, 2024 12:23
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix ! Do we need width/flex grow/shrink ? It seems it's working without

@sim51
Copy link
Contributor Author

sim51 commented Jul 3, 2024

Have you tested on chrome ?
The initial bug is only visible on chrome not firefox.

To avoid scroll and use the full size of a div, I generally use flex, grow & shrink pattern.
It works fine even in responsive.

@SharglutDev
Copy link
Contributor

Yes even on chrome, it works without the grow/shrink/width:100%. But if you think it's gonna be more resilient with these properties, its fine by me.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@sim51 sim51 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into dev with commit c9e4826 Jul 3, 2024
17 checks passed
@sim51 sim51 deleted the bsi/map-seearch-scroll branch July 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary horizontal scroll in map search
3 participants