Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fixed bug or first number of the position field cannot be cleared #7879

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

theocrsb
Copy link
Contributor

close #7866

@theocrsb theocrsb requested a review from a team as a code owner June 28, 2024 06:52
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.53%. Comparing base (c6498a4) to head (4a8884c).

Files Patch % Lines
...ools/trackSplit/components/TrackSplitLeftPanel.tsx 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7879      +/-   ##
============================================
- Coverage     28.54%   28.53%   -0.01%     
  Complexity     2059     2059              
============================================
  Files          1249     1249              
  Lines        154182   154184       +2     
  Branches       3036     3036              
============================================
- Hits          44007    44000       -7     
- Misses       108365   108374       +9     
  Partials       1810     1810              
Flag Coverage Δ
core 74.95% <ø> (ø)
editoast 71.65% <ø> (-0.03%) ⬇️
front 10.00% <0.00%> (-0.01%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Tested

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed/tested the changes and agree with the previously made comments. Once those adjustments are made, I believe the PR will be ready to merge. Good job!

@theocrsb theocrsb force-pushed the tce/front/infra/bug/cannot-erased-field branch from ff78cf2 to 82c0fbc Compare June 28, 2024 13:08
@theocrsb theocrsb force-pushed the tce/front/infra/bug/cannot-erased-field branch from 82c0fbc to 24fc243 Compare July 1, 2024 09:50
@clarani
Copy link
Contributor

clarani commented Jul 1, 2024

Can you please squash your commits ? Thanks :)

@theocrsb theocrsb force-pushed the tce/front/infra/bug/cannot-erased-field branch from 24fc243 to 4a8884c Compare July 2, 2024 06:54
@theocrsb theocrsb added this pull request to the merge queue Jul 2, 2024
Merged via the queue into dev with commit 708c0f1 Jul 2, 2024
17 checks passed
@theocrsb theocrsb deleted the tce/front/infra/bug/cannot-erased-field branch July 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra editor : First number of Position field cannot be erased
6 participants