-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fixed bug or first number of the position field cannot be cleared #7879
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7879 +/- ##
============================================
- Coverage 28.54% 28.53% -0.01%
Complexity 2059 2059
============================================
Files 1249 1249
Lines 154182 154184 +2
Branches 3036 3036
============================================
- Hits 44007 44000 -7
- Misses 108365 108374 +9
Partials 1810 1810
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!! Tested
front/src/applications/editor/tools/trackSplit/components/TrackSplitLeftPanel.tsx
Show resolved
Hide resolved
front/src/applications/editor/tools/trackSplit/components/TrackSplitLeftPanel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed/tested the changes and agree with the previously made comments. Once those adjustments are made, I believe the PR will be ready to merge. Good job!
front/src/applications/editor/tools/trackSplit/components/TrackSplitLeftPanel.tsx
Outdated
Show resolved
Hide resolved
ff78cf2
to
82c0fbc
Compare
82c0fbc
to
24fc243
Compare
Can you please squash your commits ? Thanks :) |
24fc243
to
4a8884c
Compare
close #7866