Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: minor cleanup + bugfix #7869

Merged
merged 3 commits into from
Jun 27, 2024
Merged

core: stdcm: minor cleanup + bugfix #7869

merged 3 commits into from
Jun 27, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jun 27, 2024

  • Fix formatting of edge / node comments. It got weird when going to java to kotlin, then worse with the auto-formatter
  • Remove unused fields in STDCMEdge
  • Small bugfix on V1 with time since departure

eckter added 2 commits June 27, 2024 15:43
The formatting got weird when going java -> kt,
and then weirder with the autoformatting
@eckter eckter requested a review from Erashin June 27, 2024 13:49
@eckter eckter requested a review from a team as a code owner June 27, 2024 13:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.54%. Comparing base (0c3db4e) to head (1a4cce2).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7869      +/-   ##
============================================
- Coverage     28.54%   28.54%   -0.01%     
- Complexity     2059     2060       +1     
============================================
  Files          1249     1249              
  Lines        154130   154183      +53     
  Branches       3040     3041       +1     
============================================
+ Hits          44003    44006       +3     
- Misses       108313   108363      +50     
  Partials       1814     1814              
Flag Coverage Δ
core 74.96% <100.00%> (-0.05%) ⬇️
editoast 71.64% <ø> (-0.11%) ⬇️
front 10.01% <ø> (+<0.01%) ⬆️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter changed the title core: stdcm: minor cleanup core: stdcm: minor cleanup + bugfix Jun 27, 2024
@eckter eckter enabled auto-merge June 27, 2024 14:03
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the catch, had not thought to run the v1 benchmark on my previous pr.

@eckter eckter added this pull request to the merge queue Jun 27, 2024
Merged via the queue into dev with commit 891f5fd Jun 27, 2024
17 checks passed
@eckter eckter deleted the ech/stdcm-cleanup branch June 27, 2024 14:21
@eckter eckter self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants