editoast: create editoast_models and move model v2 database tools

[Wadjetz]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.41%. Comparing base (4e8be63) to head (e14e6f5).
Report is 7 commits behind head on dev.

Files	Patch %	Lines
editoast/editoast_models/src/db_connection_pool.rs	62.50%	3 Missing ⚠️
editoast/src/generated_data/error/mod.rs	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #7864      +/-   ##
============================================
- Coverage     28.45%   28.41%   -0.04%     
  Complexity     2059     2059              
============================================
  Files          1256     1264       +8     
  Lines        154603   155097     +494     
  Branches       3049     3053       +4     
============================================
+ Hits          43989    44078      +89     
- Misses       108797   109198     +401     
- Partials       1817     1821       +4     

Flag	Coverage Δ
core	75.00% <ø> (ø)
editoast	71.62% <87.50%> (+0.02%)	⬆️
front	9.99% <ø> (+0.02%)	⬆️
gateway	2.34% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[flomonster]

LGTM

[woshilapin]

Yes, I did it, I reviewed it all 🎉 Thank you for this refactorization. Don't forget the license.

[leovalais]

Thanks for this big refactoring 😄
(I don't believe I've checked this many "viewed" since the switch to diesel_async 😅)

I'll summarize here what we discussed yesterday so that we're all on the same page.

On errors

1. Although the crate editoast_models now exists, we still can't move models into it as they all rely on InternalError.
2. The first step would be to redesign the failures of ModelV2's API.
3. Then we'd have to figure out a way to forward the information of the errors defined in sub-crates up to editoast_views without manually reading all fields of all variants.
4. Only then will we be able to start moving models around.

On diesel* dependencies

The goal is to remove the diesel dependencies in all crates but editoast_models.

1. We need to finalize the pool V2 and tests migration (which depends on dropping TSV1 ofc 🙃)
2. The DbConnection type must be made opaque.
3. All db queries in the views must be moved into the most relevant model.

That's all I believe?