Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: sim: ignore zero-length margin ranges #7847

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jun 26, 2024

Fix #7845

First and second steps are overlapping operational points

@eckter eckter requested a review from a team as a code owner June 26, 2024 09:47
@eckter eckter requested a review from Erashin June 26, 2024 09:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.68%. Comparing base (535a3db) to head (b143200).
Report is 1 commits behind head on dev.

Files Patch % Lines
...r/sncf/osrd/standalone_sim/StandaloneSimulation.kt 0.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7847      +/-   ##
============================================
- Coverage     28.69%   28.68%   -0.02%     
  Complexity     2058     2058              
============================================
  Files          1249     1249              
  Lines        154409   154412       +3     
  Branches       3040     3041       +1     
============================================
- Hits          44304    44288      -16     
- Misses       108292   108310      +18     
- Partials       1813     1814       +1     
Flag Coverage Δ
core 74.99% <0.00%> (-0.02%) ⬇️
editoast 71.97% <ø> (-0.06%) ⬇️
front 10.01% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Jun 26, 2024
Merged via the queue into dev with commit 7373ef1 Jun 26, 2024
17 checks passed
@eckter eckter deleted the ech/ignore-zero-length-margins branch June 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation assert check failed
3 participants