Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor infra tests part 6 #7839

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jun 25, 2024

Part of #6980

@hamz2a hamz2a requested a review from a team as a code owner June 25, 2024 15:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.68%. Comparing base (24485e2) to head (805f5f4).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7839      +/-   ##
============================================
+ Coverage     28.64%   28.68%   +0.03%     
  Complexity     2058     2058              
============================================
  Files          1247     1249       +2     
  Lines        154277   154409     +132     
  Branches       3029     3040      +11     
============================================
+ Hits          44199    44295      +96     
- Misses       108277   108301      +24     
- Partials       1801     1813      +12     
Flag Coverage Δ
core 75.01% <ø> (ø)
editoast 72.00% <100.00%> (+0.15%) ⬆️
front 10.01% <ø> (+<0.01%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Warning

Not tested. I trust the CI 😅

@hamz2a hamz2a added this pull request to the merge queue Jun 25, 2024
Merged via the queue into dev with commit d0d1086 Jun 25, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-refactor-infra-tests-part-6 branch June 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants