Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto stops table #7834

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jun 24, 2024

Pure refacto, no change in behavior

  • moved table columns to a separate file, with the use of cx for classes
  • keyColumn doesn’t need type params, types is inferred from the type of the array Column<PathWaypointColumn>[]
  • some simplifications

@anisometropie anisometropie requested a review from a team as a code owner June 24, 2024 21:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 1.72414% with 114 lines in your changes missing coverage. Please review.

Project coverage is 28.44%. Comparing base (4e8be63) to head (446b246).
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/modules/timesStops/TimeStopsColumns.tsx 0.00% 92 Missing and 1 partial ⚠️
front/src/modules/timesStops/TimesStops.tsx 0.00% 14 Missing and 1 partial ⚠️
front/src/modules/timesStops/TimeInput.tsx 0.00% 4 Missing and 1 partial ⚠️
front/src/modules/timesStops/utils.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7834      +/-   ##
============================================
- Coverage     28.45%   28.44%   -0.01%     
  Complexity     2059     2059              
============================================
  Files          1256     1256              
  Lines        154603   154616      +13     
  Branches       3049     3049              
============================================
- Hits          43989    43985       -4     
- Misses       108797   108814      +17     
  Partials       1817     1817              
Flag Coverage Δ
core 75.00% <ø> (ø)
editoast 71.57% <ø> (-0.03%) ⬇️
front 9.96% <1.72%> (+<0.01%) ⬆️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisometropie anisometropie force-pushed the vcs/7757/output-table-for-simulation branch 3 times, most recently from a35e6fc to 99e3bda Compare June 25, 2024 12:34
@theocrsb
Copy link
Contributor

LGTM and tested

@anisometropie anisometropie force-pushed the vcs/7757/output-table-for-simulation branch 2 times, most recently from de8f44c to fb6cefb Compare July 2, 2024 17:24
front/src/modules/timesStops/TimeColumnComponent.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/utils.ts Outdated Show resolved Hide resolved
@anisometropie anisometropie force-pushed the vcs/7757/output-table-for-simulation branch 2 times, most recently from 44f6876 to 5827d95 Compare July 3, 2024 07:40
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@SharglutDev SharglutDev enabled auto-merge July 3, 2024 08:32
@anisometropie anisometropie force-pushed the vcs/7757/output-table-for-simulation branch from 5827d95 to 48df48a Compare July 3, 2024 08:33
@anisometropie anisometropie force-pushed the vcs/7757/output-table-for-simulation branch from 48df48a to 446b246 Compare July 3, 2024 10:03
@SharglutDev SharglutDev added this pull request to the merge queue Jul 3, 2024
Merged via the queue into dev with commit dd318a9 Jul 3, 2024
17 checks passed
@SharglutDev SharglutDev deleted the vcs/7757/output-table-for-simulation branch July 3, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants