-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: use nodes in stdcm priority queue and replace weight by clear comparison #7830
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7830 +/- ##
============================================
+ Coverage 28.65% 28.67% +0.02%
- Complexity 2058 2059 +1
============================================
Files 1247 1249 +2
Lines 154280 154443 +163
Branches 3031 3040 +9
============================================
+ Hits 44202 44292 +90
- Misses 108276 108337 +61
- Partials 1802 1814 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b7608f1
to
d9b6616
Compare
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt
Outdated
Show resolved
Hide resolved
Exiting early should be mostly straightforward, like
We shouldn't have no value there. Ideally there shouldn't be any default value, or null if we can't have it when initializing (with If we do want a default value, it should be optimistic (i.e. 0) |
7279f4b
to
d59bbae
Compare
7f98e70
to
96b8f78
Compare
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt
Outdated
Show resolved
Hide resolved
96b8f78
to
b707c85
Compare
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt
Outdated
Show resolved
Hide resolved
4b4c007
to
8fd189f
Compare
8fd189f
to
5acf0be
Compare
Fixes #7581 and #7582.