Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem for export and import json #7829

Merged

Conversation

theocrsb
Copy link
Contributor

the export format doesn't match (it was nested in an object but an array was expected) additionnaly the 'timetable_id' property needed to be removed

close #7468

@theocrsb theocrsb requested review from emersion and flomonster June 24, 2024 10:22
@theocrsb theocrsb requested a review from a team as a code owner June 24, 2024 10:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.64%. Comparing base (c084bd6) to head (a7afb65).

Files Patch % Lines
...hedule/components/TimetableV2/TimetableToolbar.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7829      +/-   ##
============================================
- Coverage     28.65%   28.64%   -0.01%     
  Complexity     2058     2058              
============================================
  Files          1247     1247              
  Lines        154280   154280              
  Branches       3031     3031              
============================================
- Hits          44203    44190      -13     
- Misses       108275   108288      +13     
  Partials       1802     1802              
Flag Coverage Δ
core 75.02% <ø> (ø)
editoast 71.81% <ø> (-0.05%) ⬇️
front 10.01% <0.00%> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. You just need to correct your commit.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/fix-export-train-schedules-json branch from 9a936c8 to a7afb65 Compare June 24, 2024 15:27
@SharglutDev SharglutDev added this pull request to the merge queue Jun 24, 2024
Merged via the queue into dev with commit 54e17df Jun 24, 2024
17 checks passed
@SharglutDev SharglutDev deleted the tce/front/trainschedule/fix-export-train-schedules-json branch June 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export train schedules TS2
4 participants