Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add download button for exporting selected train schedules in json format #7809

Merged

Conversation

theocrsb
Copy link
Contributor

add button in tsv2 for exporting selected train schedules in json format whitout id

close #7468

@theocrsb theocrsb requested a review from a team as a code owner June 20, 2024 15:39
@emersion emersion requested review from clarani and emersion June 20, 2024 17:29
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, good job ! Left one comment

@theocrsb theocrsb force-pushed the tce/front/trainschedule/export-train-schedules-json branch from 7475cfc to 9d60da4 Compare June 21, 2024 09:56
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR ! Left you some comments

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 18.56%. Comparing base (bffd8c1) to head (615d90c).

Files Patch % Lines
...hedule/components/TimetableV2/TimetableToolbar.tsx 0.00% 28 Missing ⚠️
...ules/trainschedule/components/TimetableV2/hooks.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (bffd8c1) and HEAD (615d90c). Click for more details.

HEAD has 5 uploads less than BASE | Flag | BASE (bffd8c1) | HEAD (615d90c) | |------|------|------| |railjson_generator|2|1| |gateway|2|1| |tests|2|1| |front|2|1| |core|2|1|
Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7809       +/-   ##
=============================================
- Coverage     28.65%   18.56%   -10.10%     
  Complexity     2058     2058               
=============================================
  Files          1247      972      -275     
  Lines        154254   125077    -29177     
  Branches       3031     3031               
=============================================
- Hits          44203    23219    -20984     
+ Misses       108249   100056     -8193     
  Partials       1802     1802               
Flag Coverage Δ
core 75.02% <ø> (ø)
editoast ?
front 10.01% <0.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/export-train-schedules-json branch from 4fb6bee to 8167f71 Compare June 21, 2024 14:54
@theocrsb theocrsb force-pushed the tce/front/trainschedule/export-train-schedules-json branch from 8167f71 to 615d90c Compare June 21, 2024 14:59
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, great job ! 🚀

@SharglutDev SharglutDev enabled auto-merge June 21, 2024 15:02
@SharglutDev SharglutDev added this pull request to the merge queue Jun 21, 2024
Merged via the queue into dev with commit 22d010d Jun 21, 2024
17 checks passed
@SharglutDev SharglutDev deleted the tce/front/trainschedule/export-train-schedules-json branch June 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export train schedules TS2
6 participants