-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add download button for exporting selected train schedules in json format #7809
front: add download button for exporting selected train schedules in json format #7809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM, good job ! Left one comment
front/src/modules/trainschedule/components/TimetableV2/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
7475cfc
to
9d60da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR ! Left you some comments
front/src/modules/trainschedule/components/TimetableV2/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/TimetableV2/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## dev #7809 +/- ##
=============================================
- Coverage 28.65% 18.56% -10.10%
Complexity 2058 2058
=============================================
Files 1247 972 -275
Lines 154254 125077 -29177
Branches 3031 3031
=============================================
- Hits 44203 23219 -20984
+ Misses 108249 100056 -8193
Partials 1802 1802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4fb6bee
to
8167f71
Compare
8167f71
to
615d90c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, great job ! 🚀
add button in tsv2 for exporting selected train schedules in json format whitout id
close #7468