core: reduce path requirement to compute spacing resource uses #7808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to require path until it includes a zone that isn't necessary for the train. But we don't need to know which precise block it is, it doesn't need to be included in the path.
eckter
force-pushed
the
ech/reduce-path-requirement
branch
from
aca10b2 to
d983224
Compare
Khoyo
approved these changes
Jun 20, 2024
Erashin
approved these changes
Jun 20, 2024
bougue-pe
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to require path until it includes a zone that isn't necessary for the train. But we don't need to know which precise block it is, it doesn't need to be included in the path.
Fix #7788, there's a little more explanation there with a fancy drawing
Change summary: we rely on the
followingZoneStateparameter ofSignalingSimulator.evaluate()to figure out if a zone affects the signal (if the end of the path has been reached). This lets us peek one zone further than before.