Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: stdcm: minor improvements #7807

Merged
merged 2 commits into from
Jun 20, 2024
Merged

core: stdcm: minor improvements #7807

merged 2 commits into from
Jun 20, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jun 20, 2024

No description provided.

@eckter
core: stdcm: filter out edges with infinite weight
e13c7a9 
This happens when all the paths left can't
reach the destination in time
@eckter eckter requested a review from a team as a code owner June 20, 2024 14:40
@eckter eckter requested a review from Erashin June 20, 2024 14:40
@bougue-pe bougue-pe self-requested a review June 20, 2024 14:55
Erashin
Erashin approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, albeit the small question.

core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt Show resolved Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt Show resolved Hide resolved
bougue-pe
bougue-pe approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the small commits too

core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt Show resolved Hide resolved
@eckter
core: stdcm: fix crash on malformed steps
19eba8a 
The previous assert triggered when
a step had several locations on the same edge
@eckter eckter force-pushed the ech/minor-stdcm-bugfixes branch from 985e31f to 19eba8a Compare June 20, 2024 15:10
@eckter eckter enabled auto-merge June 20, 2024 15:19
@eckter eckter added this pull request to the merge queue Jun 20, 2024
@eckter eckter self-assigned this Jun 20, 2024
Merged via the queue into dev with commit f0e96c3 Jun 20, 2024
17 checks passed
@eckter eckter deleted the ech/minor-stdcm-bugfixes branch June 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erashin Erashin Erashin approved these changes

@bougue-pe bougue-pe bougue-pe approved these changes

Assignees

@eckter eckter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eckter @Erashin @bougue-pe