front: fix infinite scrolling in editor error list modal #7793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal is not inserted under the .editor-root element. As a result, the `overflow: auto` rule wasn't applied to the #errors-list-container element and <InfiniteScroll> was not catching scroll events. Closes: #7711
errors is always set to a non-null array.
kmer2016
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal is not inserted under the .editor-root element. As a
result, the
overflow: autorule wasn't applied to the#errors-list-container element and
<InfiniteScroll>was notcatching scroll events.
(A small cleanup is also included as a second commit.)
Closes: #7711