Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix negative budget in project and study #7770

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jun 18, 2024

close #7268

to test this, try :

  • paste negative number in the field
  • enter '-100'
  • decrement the input field bellow 0

@theocrsb theocrsb requested a review from a team as a code owner June 18, 2024 13:34
@theocrsb theocrsb requested review from clarani and SarahBellaha June 18, 2024 13:35
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug/negativ-value-in-field-estimated-budget branch from 6ba8753 to 50d32d2 Compare June 19, 2024 15:38
@theocrsb
Copy link
Contributor Author

Just amended one last thing : check in the onChange if the value is >=0 (for the useCase when a user copy/paste a negative number)

@Math-R Math-R added this pull request to the merge queue Jun 21, 2024
Merged via the queue into dev with commit 8382bd1 Jun 21, 2024
17 checks passed
@Math-R Math-R deleted the tce/front/trainschedule/bug/negativ-value-in-field-estimated-budget branch June 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative budget in project/Study
3 participants