editoast: stdcm: make max_run_time optional, computed if missing #7751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7751 +/- ##
=============================================
- Coverage 28.54% 18.48% -10.07%
Complexity 2038 2038
=============================================
Files 1243 970 -273
Lines 153525 124630 -28895
Branches 3008 3012 +4
=============================================
- Hits 43825 23035 -20790
+ Misses 107909 99804 -8105
Partials 1791 1791
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/compute-max-running-time
branch
from
123b40d to
3fdd61a
Compare
woshilapin
approved these changes
Jun 18, 2024
eckter
force-pushed
the
ech/compute-max-running-time
branch
from
5439cd3 to
098ecce
Compare
eckter
force-pushed
the
ech/compute-max-running-time
branch
from
098ecce to
a13017f
Compare
Khoyo
approved these changes
Jun 19, 2024
eckter
force-pushed
the
ech/compute-max-running-time
branch
from
a13017f to
b642a73
Compare
eckter
force-pushed
the
ech/compute-max-running-time
branch
from
b642a73 to
fdf3527
Compare
Update editoast/src/views/v2/timetable/stdcm.rs Co-authored-by: Jean SIMARD <woshilapin@tuziwo.info>
eckter
force-pushed
the
ech/compute-max-running-time
branch
from
fdf3527 to
0388387
Compare
woshilapin
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7695
For more context: the reason we want to do this in editoast and not in core is because it will let us pre-filter resource uses, the ones in the actual stdcm request from editoast to core
API change summary: