Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warning and fix cargo-chef version #7721

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster requested a review from a team as a code owner June 14, 2024 13:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.54%. Comparing base (f7b218a) to head (68346ae).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7721      +/-   ##
============================================
- Coverage     28.54%   28.54%   -0.01%     
  Complexity     2038     2038              
============================================
  Files          1243     1243              
  Lines        153525   153525              
  Branches       3008     3008              
============================================
- Hits          43826    43817       -9     
- Misses       107908   107917       +9     
  Partials       1791     1791              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 72.05% <ø> (-0.04%) ⬇️
front 9.83% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we pin the clippy version, do we need to add the #[allow(dead_code)]? Is maybe this version the first to trigger the clippy check?

At any rate, LGTM!

@flomonster
Copy link
Contributor Author

If we pin the clippy version, do we need to add the #[allow(dead_code)]? Is maybe this version the first to trigger the clippy check?

This is the first version to trigger the error.

@flomonster flomonster requested a review from ElysaSrc June 14, 2024 13:34
@emersion
Copy link
Member

Makes sense!

@Khoyo Khoyo added this pull request to the merge queue Jun 14, 2024
Merged via the queue into dev with commit 66b26ab Jun 14, 2024
17 checks passed
@Khoyo Khoyo deleted the fam/fix-gateway-clippy branch June 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants