editoast: use default value for missing SignalSncfExtension::side #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomonster
approved these changes
Jun 14, 2024
|
You have to regenerate the openapi using |
emersion
force-pushed
the
emersion/signal-api-default
branch
from
82eac83 to
4f12b8d
Compare
|
Indeed, done! |
woshilapin
approved these changes
Jun 14, 2024
The JSON Schema has this field marked as optional. Instead of rejecting requests which don't include the field, fill the field with the default value. This still isn't enough to fix the original bug, because the form doesn't reflect the correct default (shows "LEFT" instead of "CENTER" initially, even if the field is undefined). But I believe it's still worth fixing editoast. References: OpenRailAssociation#7445
emersion
force-pushed
the
emersion/signal-api-default
branch
from
4f12b8d to
3f4112e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON Schema has this field marked as optional. Instead of rejecting requests which don't include the field, fill the field with the default value.
This still isn't enough to fix the original bug, because the form doesn't reflect the correct default (shows "LEFT" instead of "CENTER" initially, even if the field is undefined). But I believe it's still worth fixing editoast.
References: #7445