-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix GET interaction after a drag and drop (ts v2) #7673
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7673 +/- ##
============================================
+ Coverage 28.48% 28.54% +0.05%
Complexity 2038 2038
============================================
Files 1243 1243
Lines 153360 153515 +155
Branches 3008 3008
============================================
+ Hits 43682 43816 +134
- Misses 107887 107908 +21
Partials 1791 1791
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, I still have a strange behavior after dragging a train :
enregistrement-de-lecran-2024-06-13-a-162841_a61kKLbT.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss this with the POs. The component was broken and not used, so it was decided several months ago to comment it. I believe we don't need it anymore indeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
1b8c782
to
1ee139a
Compare
closes #7576