Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix GET interaction after a drag and drop (ts v2) #7673

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jun 7, 2024

closes #7576

@clarani clarani requested a review from a team as a code owner June 7, 2024 15:51
@clarani clarani self-assigned this Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 1.38889% with 71 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (40bba33) to head (1b8c782).
Report is 11 commits behind head on dev.

Files Patch % Lines
...ult/components/SpaceTimeChart/SpaceTimeChartV2.tsx 0.00% 67 Missing ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 3 Missing ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7673      +/-   ##
============================================
+ Coverage     28.48%   28.54%   +0.05%     
  Complexity     2038     2038              
============================================
  Files          1243     1243              
  Lines        153360   153515     +155     
  Branches       3008     3008              
============================================
+ Hits          43682    43816     +134     
- Misses       107887   107908      +21     
  Partials       1791     1791              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 72.06% <ø> (+0.14%) ⬆️
front 9.83% <1.38%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I still have a strange behavior after dragging a train :

enregistrement-de-lecran-2024-06-13-a-162841_a61kKLbT.mp4

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM 💪

good to see the pointer synchronization back

can you add a more explicit comment about why the timeline is disabled? (in fact, do we really need to keep this?)

image

@clarani
Copy link
Contributor Author

clarani commented Jun 14, 2024

I think we should discuss this with the POs. The component was broken and not used, so it was decided several months ago to comment it. I believe we don't need it anymore indeed

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@clarani clarani force-pushed the cni-7576-fix-enable-interactivity-ts-v2 branch from 1b8c782 to 1ee139a Compare June 18, 2024 15:39
@clarani clarani enabled auto-merge June 18, 2024 15:39
@clarani clarani added this pull request to the merge queue Jun 18, 2024
Merged via the queue into dev with commit 09e8d71 Jun 18, 2024
17 checks passed
@clarani clarani deleted the cni-7576-fix-enable-interactivity-ts-v2 branch June 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSv2: Dragging a train on space time chart sometimes breaks the chart synchronizer
5 participants