Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: avoid a NaN in allowance ratio #7640

Merged
merged 2 commits into from
Jun 6, 2024
Merged

core: stdcm: avoid a NaN in allowance ratio #7640

merged 2 commits into from
Jun 6, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jun 6, 2024

Fix a bug where we would fail to find a path for no apparent reason.

Add a few NaN checking assert, as well as some basic logging (in a separate commit)

@eckter eckter requested a review from a team as a code owner June 6, 2024 12:53
@eckter eckter requested review from multun and Erashin June 6, 2024 12:53
@eckter eckter force-pushed the ech/fix-stdcm-nan branch from 0fc0821 to 9ccab99 Compare June 6, 2024 12:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (d5610e2) to head (0fc0821).
Report is 7 commits behind head on dev.

Current head 0fc0821 differs from pull request most recent head 9ccab99

Please upload reports for the commit 9ccab99 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7640       +/-   ##
=============================================
+ Coverage     28.47%   87.49%   +59.01%     
=============================================
  Files          1242       31     -1211     
  Lines        153171     1535   -151636     
  Branches       3004        0     -3004     
=============================================
- Hits          43614     1343    -42271     
+ Misses       107769      192   -107577     
+ Partials       1788        0     -1788     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Jun 6, 2024
Merged via the queue into dev with commit 8392e7b Jun 6, 2024
17 checks passed
@eckter eckter deleted the ech/fix-stdcm-nan branch June 6, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants