core: choose arrivalAt/departureFrom in envelope interpolation #7609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7609 +/- ##
============================================
- Coverage 28.62% 28.61% -0.01%
- Complexity 2038 2052 +14
============================================
Files 1244 1244
Lines 153668 153680 +12
Branches 3012 3018 +6
============================================
- Hits 43985 43974 -11
- Misses 107892 107913 +21
- Partials 1791 1793 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
force-pushed
the
peb/core/improve_interpolate_interface
branch
3 times, most recently
from
149d726 to
6fde773
Compare
eckter
reviewed
Jun 14, 2024
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/Envelope.java
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/Envelope.java
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/EnvelopeConcat.java
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/sncf/osrd/standalone_sim/ScheduleMetadataExtractor.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/sncf/osrd/standalone_sim/ScheduleMetadataExtractor.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/sncf/osrd/standalone_sim/StandaloneSim.java
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/ScheduleMetadataExtractorV2.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/ScheduleMetadataExtractorV2.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/PostProcessingSimulation.kt
Outdated
Show resolved
Hide resolved
|
Thanks a lot for this PR, it's a lot clearer than before and it must have been tedious |
bougue-pe
force-pushed
the
peb/core/improve_interpolate_interface
branch
from
6fde773 to
b7f044e
Compare
eckter
approved these changes
Jun 18, 2024
Khoyo
approved these changes
Jun 18, 2024
interpolateTotalTime() is removed, in favor of one of: * interpolateDepartureFrom() (which was the previous behavior) * interpolateArrivalAt() also: * little cleanup on clamp
bougue-pe
force-pushed
the
peb/core/improve_interpolate_interface
branch
from
b7f044e to
f328a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interpolateTotalTime()is removed, in favor of one of:interpolateDepartureFrom()(which was the previous behavior)interpolateArrivalAt()also:
TODO:
Follow-up on #7322 (comment)