Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor rollings stocks, livery, electrical profiles tests #7580

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jun 3, 2024

part of #6980

Refactor of tests for:

  • Rolling stock
  • Rolling stock livery
  • Electrical profiles

@Wadjetz Wadjetz added area:editoast Work on Editoast Service kind:tests Writing unit / e2e and integration tests kind:refacto-task Task related to Refactorization Epic labels Jun 3, 2024
@Wadjetz Wadjetz self-assigned this Jun 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.42%. Comparing base (db459df) to head (5f43456).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7580       +/-   ##
=============================================
- Coverage     28.44%   18.42%   -10.03%     
  Complexity     2038     2038               
=============================================
  Files          1242      970      -272     
  Lines        153207   124487    -28720     
  Branches       3008     3008               
=============================================
- Hits          43574    22932    -20642     
+ Misses       107842    99764     -8078     
  Partials       1791     1791               
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast ?
front 9.83% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/refactor-rollings-stocks-tests branch 3 times, most recently from e3c1574 to 49b05c1 Compare June 4, 2024 10:55
@Wadjetz Wadjetz marked this pull request as ready for review June 4, 2024 11:14
@Wadjetz Wadjetz requested a review from a team as a code owner June 4, 2024 11:14
@Wadjetz Wadjetz force-pushed the ebe/refactor-rollings-stocks-tests branch 2 times, most recently from 58ac72a to febee60 Compare June 6, 2024 09:53
@Wadjetz Wadjetz changed the title editoast: refactor rollings stocks tests editoast: refactor rollings stocks, livery, electrical profiles tests Jun 6, 2024
@Wadjetz Wadjetz force-pushed the ebe/refactor-rollings-stocks-tests branch 2 times, most recently from 3c5a904 to 4986a2c Compare June 6, 2024 10:13
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work on the tests, thank you 🙏 Only minor comments.

editoast/src/modelsv2/fixtures.rs Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/rolling_stock_model.rs Outdated Show resolved Hide resolved
editoast/src/views/light_rolling_stocks.rs Outdated Show resolved Hide resolved
editoast/src/views/rolling_stocks/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/rolling_stocks/mod.rs Show resolved Hide resolved
@Wadjetz Wadjetz force-pushed the ebe/refactor-rollings-stocks-tests branch from 4986a2c to 5f43456 Compare June 6, 2024 15:26
@Wadjetz Wadjetz added this pull request to the merge queue Jun 7, 2024
Merged via the queue into dev with commit b9c43e4 Jun 7, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/refactor-rollings-stocks-tests branch June 7, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic kind:tests Writing unit / e2e and integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants