-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infra editor autofix for operational points parts #7571
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7571 +/- ##
============================================
+ Coverage 28.48% 28.54% +0.05%
Complexity 2038 2038
============================================
Files 1243 1243
Lines 153384 153519 +135
Branches 3008 3008
============================================
+ Hits 43698 43824 +126
- Misses 107895 107904 +9
Partials 1791 1791
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test on that please?
Thanks for this, it should ease infra-edition very much 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more autofix, yeah 🎉 I'd be nice to have a test. That said, I know there is feature freeze tonight, I'd be fine to merge it and add a test later.
d25faf3
to
ecba4e7
Compare
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After resolving the other comments, it will be a great fix, thanks !
ecba4e7
to
7345e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks !
No description provided.