Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infra editor autofix for operational points parts #7571

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

flomonster
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 96.81529% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (15d8952) to head (7345e79).

Files Patch % Lines
...st/src/views/infra/auto_fixes/operational_point.rs 96.35% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7571      +/-   ##
============================================
+ Coverage     28.48%   28.54%   +0.05%     
  Complexity     2038     2038              
============================================
  Files          1243     1243              
  Lines        153384   153519     +135     
  Branches       3008     3008              
============================================
+ Hits          43698    43824     +126     
- Misses       107895   107904       +9     
  Partials       1791     1791              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 72.07% <96.81%> (+0.09%) ⬆️
front 9.83% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster self-assigned this May 31, 2024
@flomonster flomonster changed the title editoast: add autofix of operational points parts Add infra editor autofix for operational points parts May 31, 2024
@flomonster flomonster marked this pull request as ready for review May 31, 2024 10:12
@flomonster flomonster requested a review from a team as a code owner May 31, 2024 10:12
@leovalais leovalais self-requested a review May 31, 2024 13:46
@flomonster flomonster enabled auto-merge May 31, 2024 13:46
@flomonster flomonster requested review from woshilapin and bougue-pe and removed request for leovalais May 31, 2024 13:47
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test on that please?

Thanks for this, it should ease infra-edition very much 🙏

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more autofix, yeah 🎉 I'd be nice to have a test. That said, I know there is feature freeze tonight, I'd be fine to merge it and add a test later.

@flomonster flomonster force-pushed the fam/add-autofix-op branch 2 times, most recently from d25faf3 to ecba4e7 Compare June 6, 2024 09:04
@flomonster flomonster marked this pull request as draft June 6, 2024 14:06
auto-merge was automatically disabled June 6, 2024 14:06

Pull request was converted to draft

Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After resolving the other comments, it will be a great fix, thanks !

@flomonster flomonster force-pushed the fam/add-autofix-op branch from ecba4e7 to 7345e79 Compare June 13, 2024 13:19
@flomonster flomonster marked this pull request as ready for review June 13, 2024 13:20
@flomonster flomonster enabled auto-merge June 13, 2024 13:21
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this!

@flomonster flomonster requested a review from Tguisnet June 13, 2024 15:48
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks !

@flomonster flomonster added this pull request to the merge queue Jun 13, 2024
Merged via the queue into dev with commit f7b218a Jun 13, 2024
17 checks passed
@flomonster flomonster deleted the fam/add-autofix-op branch June 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants