Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More OpenApi annotations for /infra endpoints #7551

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented May 29, 2024

Important

Deletes the GET /infra/cache_status endpoint since the front-end doesn't use it (it wasn't even included in the openapi_legacy).
I hardly imagine that other editoast consumers use it, especially since it's not documented.

@leovalais leovalais requested a review from a team as a code owner May 29, 2024 15:05
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.36%. Comparing base (3906d4d) to head (eb2d663).
Report is 9 commits behind head on dev.

Files Patch % Lines
front/src/common/api/osrdEditoastApi.ts 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7551      +/-   ##
============================================
- Coverage     29.38%   29.36%   -0.02%     
  Complexity     2014     2014              
============================================
  Files          1200     1200              
  Lines        147465   147418      -47     
  Branches       2894     2894              
============================================
- Hits          43328    43294      -34     
+ Misses       102433   102420      -13     
  Partials       1704     1704              
Flag Coverage Δ
core 75.05% <ø> (-0.01%) ⬇️
editoast 72.49% <100.00%> (+<0.01%) ⬆️
front 9.75% <90.90%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais added this pull request to the merge queue May 30, 2024
Merged via the queue into dev with commit cfeb8eb May 30, 2024
17 checks passed
@leovalais leovalais deleted the lva/more-infra-utoipa branch May 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants