Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix input to TrainScheduleV2 into 'Offset<TravelledPath>' #7532

Merged
merged 1 commit into from
May 29, 2024

Conversation

woshilapin
Copy link
Contributor

No description provided.

@woshilapin woshilapin requested review from eckter and bougue-pe May 28, 2024 14:39
@woshilapin woshilapin requested a review from a team as a code owner May 28, 2024 14:39
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.53%. Comparing base (e669997) to head (1ccf69b).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7532       +/-   ##
=============================================
- Coverage     29.37%   11.53%   -17.85%     
=============================================
  Files          1200      614      -586     
  Lines        147400   104852    -42548     
  Branches       2891      976     -1915     
=============================================
- Hits          43305    12098    -31207     
+ Misses       102393    91785    -10608     
+ Partials       1702      969      -733     
Flag Coverage Δ
core ?
editoast ?
front 9.76% <ø> (+<0.01%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a (integration) test for that ?
Or we just let it to the ongoing PR about on_stop_signal handling?

@woshilapin woshilapin force-pushed the wsl/fix/core/tsv2-offset-travelled-path branch from 51dff36 to 97d4eed Compare May 28, 2024 15:01
@Khoyo
Copy link
Contributor

Khoyo commented May 28, 2024

Can we add a (integration) test for that ?
Or we just let it to the ongoing PR about on_stop_signal handling?

This doesn't actually change anything except for typing. I'm not sure how you'd test that.

@woshilapin woshilapin force-pushed the wsl/fix/core/tsv2-offset-travelled-path branch 2 times, most recently from 263b2d6 to 1ccf69b Compare May 29, 2024 13:13
@woshilapin woshilapin added this pull request to the merge queue May 29, 2024
Merged via the queue into dev with commit fbc9832 May 29, 2024
17 checks passed
@woshilapin woshilapin deleted the wsl/fix/core/tsv2-offset-travelled-path branch May 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants