Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: infra: ignore OP parts on missing tracks #7519

Merged
merged 1 commit into from
May 28, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented May 27, 2024

This isn't an error in the infra editor and can't really be fixed, and users prefer that we go toward the "ignore/warning" route.

I would have included an actual warning, but that requires #6925 first.

@eckter eckter requested a review from a team as a code owner May 27, 2024 09:55
@eckter eckter requested a review from multun May 27, 2024 09:55
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.33%. Comparing base (75eb1dd) to head (4d85af6).

Files Patch % Lines
.../sim_infra/impl/new_impl/RawInfraFromRjsBuilder.kt 0.00% 1 Missing and 1 partial ⚠️
.../src/main/kotlin/fr/sncf/osrd/RawInfraRJSParser.kt 85.71% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7519      +/-   ##
============================================
- Coverage     29.34%   29.33%   -0.01%     
  Complexity     2012     2012              
============================================
  Files          1197     1197              
  Lines        147037   147041       +4     
  Branches       2890     2891       +1     
============================================
- Hits          43146    43136      -10     
- Misses       102191   102203      +12     
- Partials       1700     1702       +2     
Flag Coverage Δ
core 75.04% <66.66%> (-0.02%) ⬇️
editoast 72.49% <ø> (-0.04%) ⬇️
front 9.76% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/ignore-invalid-op-parts branch from 322c5d1 to 4d85af6 Compare May 27, 2024 12:03
@eckter eckter self-assigned this May 28, 2024
@eckter eckter added this pull request to the merge queue May 28, 2024
Merged via the queue into dev with commit 7d98c5f May 28, 2024
17 checks passed
@eckter eckter deleted the ech/ignore-invalid-op-parts branch May 28, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants