Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: refactor projects tests #7508

Merged
merged 1 commit into from
May 27, 2024
Merged

editoast: refactor projects tests #7508

merged 1 commit into from
May 27, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented May 24, 2024

No description provided.

@Wadjetz Wadjetz added area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services kind:refacto-task Task related to Refactorization Epic labels May 24, 2024
@Wadjetz Wadjetz self-assigned this May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.34%. Comparing base (4b0f2d6) to head (ee29efd).
Report is 2 commits behind head on dev.

❗ Current head ee29efd differs from pull request most recent head ee9ca14

Please upload reports for the commit ee9ca14 to get more accurate results.

Files Patch % Lines
editoast/src/views/projects.rs 81.25% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #7508   +/-   ##
=========================================
  Coverage     29.34%   29.34%           
  Complexity     2012     2012           
=========================================
  Files          1197     1198    +1     
  Lines        147039   147050   +11     
  Branches       2889     2889           
=========================================
+ Hits          43142    43155   +13     
+ Misses       102197   102195    -2     
  Partials       1700     1700
Flag Coverage Δ
core 75.07% <ø> (ø)
editoast 72.53% <90.62%> (+0.01%) ⬆️
front 9.76% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz requested a review from woshilapin May 24, 2024 08:49
@Wadjetz Wadjetz marked this pull request as ready for review May 24, 2024 08:49
@Wadjetz Wadjetz requested a review from a team as a code owner May 24, 2024 08:49
@Wadjetz Wadjetz requested a review from hamz2a May 24, 2024 09:14
hamz2a
hamz2a approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@Wadjetz Wadjetz force-pushed the ebe/editoast-test-refactors-projects branch from a62da4f to c3aa220 Compare May 24, 2024 09:23
leovalais
leovalais approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring and improving these tests :)

I have a few comments but nothing really blocking (except for the cfg_attr one).

editoast/src/modelsv2/projects.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/projects.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/projects.rs Show resolved Hide resolved
editoast/src/views/projects.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/projects.rs Outdated Show resolved Hide resolved
editoast/src/views/projects.rs Outdated Show resolved Hide resolved
editoast/src/views/projects.rs Show resolved Hide resolved
editoast/src/views/pagination.rs Outdated Show resolved Hide resolved
@Wadjetz Wadjetz force-pushed the ebe/editoast-test-refactors-projects branch 5 times, most recently from f18be82 to ee29efd Compare May 24, 2024 13:58
leovalais
leovalais reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more 😄

editoast/src/modelsv2/fixtures.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/fixtures.rs Outdated Show resolved Hide resolved
editoast/src/modelsv2/mod.rs Show resolved Hide resolved
editoast/src/modelsv2/projects.rs Show resolved Hide resolved
editoast/src/views/projects.rs Outdated Show resolved Hide resolved
@Wadjetz
editoast: refactor projects tests
ee9ca14 
Update editoast/src/views/pagination.rs

Co-authored-by: Léo Valais <leo.valais97@gmail.com>
Update editoast/src/modelsv2/projects.rs

Co-authored-by: Léo Valais <leo.valais97@gmail.com>
Update editoast/src/modelsv2/projects.rs
@Wadjetz Wadjetz force-pushed the ebe/editoast-test-refactors-projects branch from ee29efd to ee9ca14 Compare May 27, 2024 13:00
@Wadjetz Wadjetz added this pull request to the merge queue May 27, 2024
Merged via the queue into dev with commit 464ca12 May 27, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-test-refactors-projects branch May 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

@hamz2a hamz2a hamz2a approved these changes

@woshilapin woshilapin Awaiting requested review from woshilapin

Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wadjetz @codecov-commenter @leovalais @hamz2a