Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix speed limit tags filter in timetable v2 #7491

Merged
merged 1 commit into from
May 23, 2024

Conversation

SharglutDev
Copy link
Contributor

close #7490

@SharglutDev SharglutDev requested a review from a team as a code owner May 23, 2024 12:20
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 29.25%. Comparing base (fd6a65c) to head (838b660).

Files Patch % Lines
...ules/trainschedule/components/TimetableV2/hooks.ts 0.00% 11 Missing and 1 partial ⚠️
...peedLimitByTagSelector/SpeedLimitByTagSelector.tsx 0.00% 6 Missing ⚠️
...hedule/components/TimetableV2/TimetableToolbar.tsx 0.00% 1 Missing and 1 partial ⚠️
...Selector/useStoreDataForSpeedLimitByTagSelector.ts 0.00% 1 Missing ⚠️
...ules/trainschedule/components/TimetableV2/utils.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7491      +/-   ##
============================================
- Coverage     29.26%   29.25%   -0.01%     
  Complexity     2012     2012              
============================================
  Files          1194     1194              
  Lines        146864   146868       +4     
  Branches       2889     2889              
============================================
- Hits          42978    42971       -7     
- Misses       102186   102197      +11     
  Partials       1700     1700              
Flag Coverage Δ
core 75.07% <ø> (ø)
editoast 72.37% <ø> (-0.03%) ⬇️
front 9.75% <0.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well ! Ty for the fix, I just left one comment

@Math-R Math-R added this pull request to the merge queue May 23, 2024
Merged via the queue into dev with commit 4c84701 May 23, 2024
17 checks passed
@Math-R Math-R deleted the pfn/front/timetableV2/fix-speedlimittags-filter branch May 23, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter by speed limit by tag in timetable broken
4 participants