core: spacing-requirements: handle several zones before first signal #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
ech/spacing-requirement-bugfix
branch
from
6a47465 to
02c79c2
Compare
We properly generate requirement only from the first seen signal, with a special case for the first zone. That special case needs to be generalized to all zones between the start and first signal.
eckter
force-pushed
the
ech/spacing-requirement-bugfix
branch
from
02c79c2 to
e89df0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7480 +/- ##
============================================
+ Coverage 29.36% 29.40% +0.04%
- Complexity 2012 2013 +1
============================================
Files 1177 1181 +4
Lines 145975 146096 +121
Branches 2871 2874 +3
============================================
+ Hits 42867 42963 +96
- Misses 101423 101448 +25
Partials 1685 1685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Erashin
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a rare bug that has been identified by the fuzzer, there's a regression test on the branch
ech/ts2-fuzzer(though it's not related to train schedules v2).We properly generate requirement only from the first seen signal, with a special case for the first zone. That special case needs to be generalized to all zones between the start and first signal.