editoast: move sql request from /speed_limit_tags to modelsv2::infra
#7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7434 +/- ##
============================================
- Coverage 29.39% 29.39% -0.01%
Complexity 2011 2011
============================================
Files 1172 1173 +1
Lines 145257 145264 +7
Branches 2822 2822
============================================
+ Hits 42694 42696 +2
- Misses 100899 100904 +5
Partials 1664 1664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hamz2a
changed the title
/speed_limit_tags to modelsv2::infra/speed_limit_tags to modelsv2::infra
woshilapin
approved these changes
May 16, 2024
leovalais
requested changes
May 16, 2024
leovalais
reviewed
May 16, 2024
hamz2a
force-pushed
the
hai/editoast-move-sql-request--from-speed-limit-tags-views-to-infra-model
branch
from
f75883c to
95a206f
Compare
leovalais
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM, thanks! Maybe wait for @woshilapin to resolve his comment before merging.
hamz2a
force-pushed
the
hai/editoast-move-sql-request--from-speed-limit-tags-views-to-infra-model
branch
from
95a206f to
2afa513
Compare
woshilapin
approved these changes
May 16, 2024
hamz2a
deleted the
hai/editoast-move-sql-request--from-speed-limit-tags-views-to-infra-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6397