Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editoast --no-cache option #7419

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

flomonster
Copy link
Contributor

This option allows to disable caching.
It's useful for developers working on core and using editoast endpoints.

@flomonster flomonster requested a review from a team as a code owner May 15, 2024 16:39
@flomonster flomonster requested review from leovalais and Erashin May 15, 2024 16:39
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. By the way, should this option be activated by default (simplifying the developer onboarding?). No cache means no Redis to deploy locally, so it might be interesting.

editoast/src/redis_utils.rs Outdated Show resolved Hide resolved
editoast/src/redis_utils.rs Outdated Show resolved Hide resolved
editoast/src/redis_utils.rs Outdated Show resolved Hide resolved
@flomonster
Copy link
Contributor Author

Nice one. By the way, should this option be activated by default (simplifying the developer onboarding?). No cache means no Redis to deploy locally, so it might be interesting.

I don't want to enable it by default. Using docker compose we have a redis that runs easily. Disabling the cache makes the tile server very slow. Which is not good behavior, even for developers.

@flomonster flomonster force-pushed the fam/add-editoast-no-cache-option branch from 38f51c9 to b556827 Compare May 16, 2024 08:24
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 29.38%. Comparing base (39c7998) to head (020ee06).

Files Patch % Lines
editoast/src/redis_utils.rs 33.33% 6 Missing ⚠️
editoast/src/client/redis_config.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7419      +/-   ##
============================================
- Coverage     29.39%   29.38%   -0.01%     
  Complexity     2011     2011              
============================================
  Files          1171     1171              
  Lines        145240   145246       +6     
  Branches       2822     2822              
============================================
- Hits          42691    42682       -9     
- Misses       100885   100900      +15     
  Partials       1664     1664              
Flag Coverage Δ
core 75.25% <ø> (ø)
editoast 72.43% <27.27%> (-0.05%) ⬇️
front 9.82% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This option allows to disable caching. It's useful for developers
working on core and using editoast endpoints.
@flomonster flomonster force-pushed the fam/add-editoast-no-cache-option branch from b556827 to 020ee06 Compare May 16, 2024 09:11
@flomonster flomonster enabled auto-merge May 16, 2024 09:12
@flomonster flomonster added this pull request to the merge queue May 16, 2024
Merged via the queue into dev with commit e82ce9c May 16, 2024
17 checks passed
@flomonster flomonster deleted the fam/add-editoast-no-cache-option branch May 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants