-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: initialize stdcm v2 #7414
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7414 +/- ##
============================================
- Coverage 29.15% 28.98% -0.17%
Complexity 2021 2021
============================================
Files 1210 1223 +13
Lines 148187 149045 +858
Branches 2915 2934 +19
============================================
+ Hits 43202 43207 +5
- Misses 103264 104098 +834
- Partials 1721 1740 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b2eff15
to
537f7eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use const instead of function in all the files to be coherent with the existing code base
front/src/modules/rollingStock/components/RollingStockCard/useFilterRollingStock.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/rollingStock/components/RollingStockCard/useFilterRollingStock.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, thank you for the refactor. Tested and LGTM for the start of V2 implementation. Left few comments.
front/src/modules/rollingStock/components/RollingStockCard/useFilterRollingStock.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/rollingStock/components/RollingStockCard/useFilterRollingStock.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/rollingStock/components/RollingStockCard/useFilterRollingStock.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/rollingStockEditor/views/RollingStockEditor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great PR. As there has been 2 review already, I just compared your UI to the one of the model and left some comments.
front/src/applications/stdcmV2/components/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
...src/modules/rollingStock/components/RollingStockSelector/__tests__/RollingStockModal.spec.ts
Outdated
Show resolved
Hide resolved
ac29d70
to
22ebb2d
Compare
a0dc0cf
to
bd04690
Compare
bd04690
to
d434bf4
Compare
d434bf4
to
37749cd
Compare
front/src/applications/stdcmV2/components/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmOperationalPoint.tsx
Outdated
Show resolved
Hide resolved
3bf5d6d
to
0e6c3d8
Compare
740a796
to
94c1857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good !
94c1857
to
6994cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks ✅
6994cf6
to
3fcc337
Compare
Closes #7015
Implementation of STDCM V2
Completed Tasks:
Fixes #7409Key Highlights:
useSearchOperationalPoint
. This hook is now used in bothMapSearchOperationalPoint
andStdcmOperationalPoint
.useSearchOperationalPoint
to prevent changes to the CH code of main operational points (BV, 00). Selecting an empty CH code inStdcmOperationalPoint
resets the search.useStdcm
. These functions are reused inStdcmViewV1
andStdcmViewV2
.Next Steps:
Select
component.DatePicker
component.TimePicker
component.MarginPicker
component.ui-core
font.