Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display timetablev2 #7399

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented May 10, 2024

close #7486

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 3.92781% with 905 lines in your changes are missing coverage. Please review.

Project coverage is 29.25%. Comparing base (afc1c50) to head (16ed455).
Report is 22 commits behind head on dev.

Files Patch % Lines
...hedule/components/TimetableV2/TimetableToolbar.tsx 0.00% 194 Missing and 1 partial ⚠️
...ules/trainschedule/components/TimetableV2/hooks.ts 0.00% 171 Missing and 1 partial ⚠️
...le/components/TimetableV2/TimetableTrainCardV2.tsx 0.00% 123 Missing ⚠️
...ainschedule/components/TimetableV2/FilterPanel.tsx 0.00% 121 Missing and 1 partial ⚠️
...rationalStudies/views/v2/getSimulationResultsV2.ts 0.00% 99 Missing and 1 partial ⚠️
...ainschedule/components/TimetableV2/TimetableV2.tsx 0.00% 57 Missing and 1 partial ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 43 Missing ⚠️
...ules/trainschedule/components/TimetableV2/utils.ts 0.00% 32 Missing and 1 partial ⚠️
front/src/common/api/enhancedEditoastApi.ts 52.00% 24 Missing ⚠️
...les/trainschedule/components/TimetableV2/consts.ts 0.00% 14 Missing and 1 partial ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7399      +/-   ##
============================================
- Coverage     29.36%   29.25%   -0.11%     
  Complexity     2012     2012              
============================================
  Files          1177     1194      +17     
  Lines        145975   146864     +889     
  Branches       2871     2889      +18     
============================================
+ Hits          42867    42971     +104     
- Misses       101423   102193     +770     
- Partials       1685     1700      +15     
Flag Coverage Δ
core 75.07% <ø> (-0.06%) ⬇️
editoast 72.37% <ø> (+0.03%) ⬆️
front 9.75% <3.92%> (-0.04%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.23% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/adapt-trainschedule-resultsV2 branch 8 times, most recently from c158695 to e50d524 Compare May 17, 2024 16:32
@SharglutDev SharglutDev changed the title front: adapt trainschedule results for trainschedule v2 front: display timetablev2 and start adapting trainscheduleresultsv2 May 17, 2024
@SharglutDev SharglutDev force-pushed the pfn/front/adapt-trainschedule-resultsV2 branch 2 times, most recently from 6974572 to de462a9 Compare May 22, 2024 06:32
@SharglutDev SharglutDev force-pushed the pfn/front/adapt-trainschedule-resultsV2 branch from de462a9 to 16ed455 Compare May 23, 2024 10:37
@SharglutDev SharglutDev changed the title front: display timetablev2 and start adapting trainscheduleresultsv2 front: display timetablev2 May 23, 2024
@SharglutDev SharglutDev marked this pull request as ready for review May 23, 2024 10:43
@SharglutDev SharglutDev requested a review from a team as a code owner May 23, 2024 10:43
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani clarani added this pull request to the merge queue May 23, 2024
Merged via the queue into dev with commit fd6a65c May 23, 2024
17 checks passed
@clarani clarani deleted the pfn/front/adapt-trainschedule-resultsV2 branch May 23, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: adapt timetable v2
3 participants