Editoast pagination overhaul for ModelV2 list #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7397 +/- ##
=============================================
+ Coverage 29.39% 87.49% +58.09%
=============================================
Files 1173 31 -1142
Lines 145280 1535 -143745
Branches 2828 0 -2828
=============================================
- Hits 42707 1343 -41364
+ Misses 100907 192 -100715
+ Partials 1666 0 -1666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
woshilapin
requested changes
May 14, 2024
leovalais
force-pushed
the
lva/pagination-overhaul
branch
from
92b47a0 to
889430b
Compare
leovalais
force-pushed
the
lva/pagination-overhaul
branch
2 times, most recently
from
3535503 to
634c77c
Compare
leovalais
force-pushed
the
lva/pagination-overhaul
branch
from
634c77c to
7197656
Compare
woshilapin
approved these changes
May 22, 2024
leovalais
force-pushed
the
lva/pagination-overhaul
branch
from
9028831 to
e79f9a1
Compare
leovalais
force-pushed
the
lva/pagination-overhaul
branch
from
e79f9a1 to
6c9edd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7135
Tip
Better review commit by commit
The old pagination mechanism will be deprecated once all endpoints using it have been be updated.