-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add telemetry on database requests #7389
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7389 +/- ##
=============================================
+ Coverage 29.44% 87.49% +58.04%
=============================================
Files 1162 31 -1131
Lines 143499 1535 -141964
Branches 2808 0 -2808
=============================================
- Hits 42253 1343 -40910
+ Misses 99588 192 -99396
+ Partials 1658 0 -1658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice! I'm not against using the unstable feature as even if that becomes a problem, reverting that single commit wouldn't be much work and won't degrade the service. But I'm wondering whether we should be using Maybe Now that |
0d23a19
to
3b61898
Compare
I removed the unstable feature and went |
87bad14
to
b60829f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (tested + reviewed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Since @flomonster already tested it I'll just play with it later ;)
b60829f
to
ff1e7dd
Compare
The second commit tries to add identifiers in metadata of the traces. However, it seems that it would be not trivial to do it without the
valuable
feature... which is unstable..cargo/config.toml
(hence the build is failing). Needs some investigation if we want to go that path.