core: add error detail when using a route that has no exit signal #7380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
changed the title
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7380 +/- ##
============================================
+ Coverage 29.39% 29.44% +0.04%
+ Complexity 2016 2013 -3
============================================
Files 1162 1162
Lines 143505 143521 +16
Branches 2809 2814 +5
============================================
+ Hits 42184 42259 +75
+ Misses 99667 99602 -65
- Partials 1654 1660 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/detail-pathfinding-error
branch
from
ea5bf86 to
e9b777b
Compare
Erashin
approved these changes
May 15, 2024
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/pathfinding/PathfindingBlocksEndpointV2.kt
Outdated
Show resolved
Hide resolved
core/osrd-reporting/src/main/java/fr/sncf/osrd/reporting/exceptions/ErrorType.java
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathfindingBlocksEndpoint.kt
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/detail-pathfinding-error
branch
from
e9b777b to
9604c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a path that included a route that doesn't end on a block or buffer stop used to cause obscure errors at the simulation step. With this change, the error happens during the pathfinding with a error clearly pointing where to fix the infra problem.